Date: Mon, 17 Nov 2025 14:54:26 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: "David E. O'Brien" <obrien@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM Message-ID: <e75dd6bc-7e88-47c3-85e5-8efda9cabc50@FreeBSD.org> In-Reply-To: <aReiI9Zrggh0iyW1__22300.8289745607$1763156532$gmane$org@cell.glebi.us> References: <202511110246.5AB2kdQc077401__35176.4420907543$1762829211$gmane$org@gitrepo.freebsd.org> <e9235130-e317-4add-b051-53a9c7cb6bc3@FreeBSD.org> <aReiI9Zrggh0iyW1__22300.8289745607$1763156532$gmane$org@cell.glebi.us>
index | next in thread | previous in thread | raw e-mail
On 14/11/25 18:41, Gleb Smirnoff wrote:
> On Fri, Nov 14, 2025 at 06:03:15PM -0300, Renato Botelho wrote:
> R> After upgrading my laptop this morning I noticed it was freezing after
> R> suspend/resume. I've bisected and ended up on this commit.
> R>
> R> I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed by
> R> f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue.
> R>
> R> My system is running today's CURRENT at 82d8a5029a80.
>
> Looks like the commit you point at can't be a culprit. Looking closer to your
> description "reverting d6f10a5d013f followed by f1b9c1aafd84 and 3deb21f1afd5"
> it seems that the only functional change is addition of device tpm and
> rdrand_rng and option RANDOM_ENABLE_TPM to the GENERIC.
>
> Can you please try unmodified main sources at 82d8a5029a80, but modify GENERIC
> to remove these two lines:
>
> +# random(4)
> +device rdrand_rng # Intel Bull Mountain RNG
> +device tpm # Trusted Platform Module
> +options RANDOM_ENABLE_TPM # enable entropy from TPM 2.0
>
> If that helps, can you please find which particular line makes the
> regression.
Hello Gleb!
I was far from keyboard during the weekend but I tested it today and
RANDOM_ENABLE_TPM is the option that trigger the issue.
I've commented out RANDOM_ENABLE_{TPM,KBD,MOUSE} on unpatched src at
82d8a5029a80 and suspend/resume worked as expected. Uncommenting
RANDOM_ENABLE_TPM made it to stop working again.
--
Renato Botelho
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e75dd6bc-7e88-47c3-85e5-8efda9cabc50>