Date: Thu, 4 Jul 2013 19:34:01 +0200 From: Andre Albsmeier <Andre.Albsmeier@siemens.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: FreeBSD-9.1: machine reboots during snapshot creation, LORs found Message-ID: <20130704173401.GA3297@bali> In-Reply-To: <20130704172528.GL91021@kib.kiev.ua> References: <20130531122611.GA6607@bali> <201305311051.03157.jhb@freebsd.org> <20130616063942.GA72803@bali> <201306171530.31208.jhb@freebsd.org> <20130704051409.GA22021@bali> <20130704052440.GG91021@kib.kiev.ua> <20130704052659.GA23398@bali> <20130704061550.GI91021@kib.kiev.ua> <20130704142919.GA1798@bali> <20130704172528.GL91021@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 04-Jul-2013 at 19:25:28 +0200, Konstantin Belousov wrote: > On Thu, Jul 04, 2013 at 04:29:19PM +0200, Andre Albsmeier wrote: > > OK, patch is applied. I will reboot the machine later > > and see what happens tomorrow in the morning. However, > > it might take a few days since the last 2 weeks all was > > fine. > > > > BTW, should this patch be used in general or is it just > > for debugging? My understanding is that it is something > > which could stay in the code... > > Patch is to improve debugging. That's what I suspected. > > I probably commit it after the issue is closed. Arguments against > the commit is that the change imposes small performance penalty > due to save and restore of the %ebp (I doubt that this is measureable > by any means). Also, arguably, such change should be done for all > functions in support.s, but bcopy() is the hot spot. Hmm, maybe it could simply get enabled conditionally through some kernel compile option which is off by default... -Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130704173401.GA3297>