Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Apr 2001 20:38:02 -0400 (EDT)
From:      Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To:        Brian Somers <brian@Awfulhak.org>
Cc:        security@FreeBSD.ORG
Subject:   Re: ntpd patch 
Message-ID:  <200104060038.UAA73318@khavrinen.lcs.mit.edu>
In-Reply-To: <200104060033.f360XfP03505@hak.lan.Awfulhak.org>
References:  <ache@nagual.pp.ru> <20010406035459.A6350@nagual.pp.ru> <200104060033.f360XfP03505@hak.lan.Awfulhak.org>

next in thread | previous in thread | raw e-mail | index | archive | help
<<On Fri, 06 Apr 2001 01:33:41 +0100, Brian Somers <brian@Awfulhak.org> said:

> I believe the int is correct.

You are mistaken.  The purpose of the cast is to defeat the automatic
promotion from `char' to `int', which causes sign-extension if `char'
is signed.  Casting to `unsigned char' prevents this from happening.

-GAWollman



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104060038.UAA73318>