Date: Fri, 6 Oct 2000 09:41:29 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Wesley Morgan <morganw@chemicals.tacorp.com> Cc: current@freebsd.org Subject: Re: panic in ufs_extattr_uepm_destroy() Message-ID: <Pine.NEB.3.96L.1001006093250.63939C-100000@fledge.watson.org> In-Reply-To: <Pine.BSF.4.21.0010052247360.71550-100000@volatile.chemicals.tacorp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 5 Oct 2000, Wesley Morgan wrote: > I'm getting a panic in ufs_extattr_uepm_destroy() because in ffs_vfsops.c > it is being called (line 788) with ump NULL: > > ufs_extattr_uepm_destroy(&ump->um_extattr); > > Of course disabling FFS_EXTATTR gets rid of this:) Hmm. I added these changes without adequate testing so as to fix a problem with Jason's addition of a lockdestroy, which also rapidly resulted in a mess :-). I'm away from my dev box right now, as I'm on travel, so haven't tested the following, but it should work. Let me know, and I'll commit it ASAP. Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services Index: ffs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v retrieving revision 1.129 diff -u -r1.129 ffs_vfsops.c --- ffs_vfsops.c 2000/10/04 04:44:51 1.129 +++ ffs_vfsops.c 2000/10/06 13:40:57 @@ -772,7 +772,7 @@ int mntflags; struct proc *p; { - register struct ufsmount *ump; + register struct ufsmount *ump = VFSTOUFS(mp); register struct fs *fs; int error, flags; @@ -794,7 +794,6 @@ if ((error = ffs_flushfiles(mp, flags, p)) != 0) return (error); } - ump = VFSTOUFS(mp); fs = ump->um_fs; if (fs->fs_ronly == 0) { fs->fs_clean = fs->fs_flags & FS_UNCLEAN ? 0 : 1; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1001006093250.63939C-100000>