Date: Fri, 06 Apr 2001 01:49:31 +0100 From: Brian Somers <brian@Awfulhak.org> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: Brian Somers <brian@Awfulhak.org>, security@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: ntpd patch Message-ID: <200104060049.f360nVP03735@hak.lan.Awfulhak.org> In-Reply-To: Message from Garrett Wollman <wollman@khavrinen.lcs.mit.edu> of "Thu, 05 Apr 2001 20:38:02 EDT." <200104060038.UAA73318@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> <<On Fri, 06 Apr 2001 01:33:41 +0100, Brian Somers <brian@Awfulhak.org> said:
>
> > I believe the int is correct.
>
> You are mistaken. The purpose of the cast is to defeat the automatic
> promotion from `char' to `int', which causes sign-extension if `char'
> is signed. Casting to `unsigned char' prevents this from happening.
Oops, yes... I guess I'll go to bed now then :*I
> -GAWollman
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104060049.f360nVP03735>