Date: Sat, 27 Oct 2018 23:31:04 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Vladimir Kondratyev <vladimir@kondratyev.su>, Vladimir Kondratyev <wulf@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339823 - in head/sys/dev: atkbdc evdev kbdmux usb/input Message-ID: <22411251-9d2b-8799-3914-28974a9710f2@freebsd.org> In-Reply-To: <82231f6b-41c4-8beb-771d-3b6ada56091c@kondratyev.su> References: <201810272022.w9RKMgOZ023575@repo.freebsd.org> <3d441b5d-e225-1226-e229-73c93f85c8a9@freebsd.org> <82231f6b-41c4-8beb-771d-3b6ada56091c@kondratyev.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/27/18 11:26 PM, Vladimir Kondratyev wrote: > On 27.10.2018 23:32, Niclas Zeising wrote: >> On 10/27/18 10:22 PM, Vladimir Kondratyev wrote: >>> Author: wulf >>> Date: Sat Oct 27 20:22:41 2018 >>> New Revision: 339823 >>> URL: https://svnweb.freebsd.org/changeset/base/339823 >>> >>> Log: >>> =C2=A0=C2=A0 evdev: Use console lock as evdev lock for all supported= keyboard >>> drivers. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Now evdev part of keyboard drivers does no= t take any locks if >>> corresponding >>> =C2=A0=C2=A0 input/eventN device node is not opened by userland cons= umers. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Do not assert console lock inside evdev to= handle the cases >>> when keyboard >>> =C2=A0=C2=A0 driver is called from some special single-threaded cont= ext like >>> shutdown >>> =C2=A0=C2=A0 thread. >>> >> Related to https://reviews.freebsd.org/D15070 ? >> > Yes it is a part of D15070. >=20 > Along with r339824 it closes all issues known to me that preventing > evdev to be enabled by default. >=20 Thank you! Any chance you can add a note in phabricator and close/abandon the review= ? Once again thank you! Regards --=20 Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22411251-9d2b-8799-3914-28974a9710f2>