Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Oct 2025 12:03:57 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 8a6bfa0455bf - main - pf tests: add missing atf_test_case lines for nat tests
Message-ID:  <202510111203.59BC3vE3040081@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=8a6bfa0455bfd4b77cb71d229b9dfca031b6703f

commit 8a6bfa0455bfd4b77cb71d229b9dfca031b6703f
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2025-10-10 15:12:36 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-10-11 11:24:25 +0000

    pf tests: add missing atf_test_case lines for nat tests
    
    The lack of these lines means we don't call the cleanup function.
    That's not as bad as it could be, because these tests are nested in a jail by
    Kyua, so most of the cleanup work (destroying jails and interfaces) is done when
    the parent jail goes away, but it's still better to have these lines.
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 tests/sys/netpfil/pf/nat.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/sys/netpfil/pf/nat.sh b/tests/sys/netpfil/pf/nat.sh
index e55f46418221..63658164c1fe 100644
--- a/tests/sys/netpfil/pf/nat.sh
+++ b/tests/sys/netpfil/pf/nat.sh
@@ -474,6 +474,7 @@ no_addrs_random_cleanup()
 	pft_cleanup
 }
 
+atf_test_case "nat_pass" "cleanup"
 nat_pass_head()
 {
 	atf_set descr 'IPv4 NAT on pass rule'
@@ -505,6 +506,7 @@ nat_pass_cleanup()
 	pft_cleanup
 }
 
+atf_test_case "nat_match" "cleanup"
 nat_match_head()
 {
 	atf_set descr 'IPv4 NAT on match rule'
@@ -644,6 +646,7 @@ map_e_pass_cleanup()
 	pft_cleanup
 }
 
+atf_test_case "binat_compat" "cleanup"
 binat_compat_head()
 {
 	atf_set descr 'IPv4 BINAT with nat ruleset'
@@ -710,6 +713,7 @@ binat_compat_cleanup()
 	kill $(cat ${PWD}/inetd_tester.pid)
 }
 
+atf_test_case "binat_match" "cleanup"
 binat_match_head()
 {
 	atf_set descr 'IPv4 BINAT with nat ruleset'



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510111203.59BC3vE3040081>