Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Mar 2006 21:47:59 GMT
From:      Wayne Salamon <wsalamon@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 92819 for review
Message-ID:  <200603052147.k25LlxaL092105@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=92819

Change 92819 by wsalamon@gretsch on 2006/03/05 21:47:32

	Audit the remaining required arguments for quotactl(), mkfifo(),
	and symlink() system calls.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#30 edit
.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#10 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#30 (text+ko) ====

@@ -191,6 +191,8 @@
 	int error;
 	struct nameidata nd;
 
+	AUDIT_ARG(cmd, uap->cmd);
+	AUDIT_ARG(uid, uap->uid);
 	if (jailed(td->td_ucred) && !prison_quotas)
 		return (EPERM);
 	mtx_lock(&Giant);
@@ -1316,6 +1318,7 @@
 	struct nameidata nd;
 	int vfslocked;
 
+	AUDIT_ARG(mode, mode);
 restart:
 	bwillwrite();
 	NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME | MPSAFE | AUDITVNODE1,
@@ -1531,6 +1534,7 @@
 		if ((error = copyinstr(path, syspath, MAXPATHLEN, NULL)) != 0)
 			goto out;
 	}
+	AUDIT_ARG(text, syspath);
 restart:
 	bwillwrite();
 	NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME | MPSAFE | AUDITVNODE1,

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#10 (text+ko) ====

@@ -547,6 +547,12 @@
 		/* Header, subject, and return tokens added at end */
 		break;
 
+	case AUE_MKFIFO:
+		if (ARG_IS_VALID(kar, ARG_MODE)) {
+			tok = au_to_arg32(2, "mode", ar->ar_arg_mode);
+			kau_write(rec, tok);
+		}
+		/* fall through */
 	case AUE_ACCESS:
 	case AUE_CHDIR:
 	case AUE_CHROOT:
@@ -555,7 +561,6 @@
 	case AUE_GETATTRLIST:
 	case AUE_NFS_GETFH:
 	case AUE_LSTAT:
-	case AUE_MKFIFO:
 	case AUE_PATHCONF:
 	case AUE_READLINK:
 	case AUE_REVOKE:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603052147.k25LlxaL092105>