Date: Thu, 07 Aug 2014 13:32:45 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <royger@FreeBSD.org> To: David Wolfskill <david@catwhisker.org>, =?ISO-8859-1?Q?Trond_Endres?= =?ISO-8859-1?Q?t=F8l?= <Trond.Endrestol@fagskolen.gjovik.no>, current@freebsd.org Subject: Re: panic: aatpic_assign_cpu: bad cookie [Was: Build machine OK; laptop panics @r269515] Message-ID: <53E363DD.4040105@FreeBSD.org> In-Reply-To: <20140806210759.GM1228@albert.catwhisker.org> References: <20140804194759.GT1228@albert.catwhisker.org> <20140805142914.GJ1228@albert.catwhisker.org> <C248C4AE-65AB-406A-A523-F7D7FAA8FBBE@FreeBSD.org> <53E1450D.5090708@protected-networks.net> <53E14CD1.20308@protected-networks.net> <8B832384-C1CC-4622-BA67-7447ECE317C9@FreeBSD.org> <alpine.BSF.2.11.1408061914220.64214@mail.fig.ol.no> <alpine.BSF.2.11.1408062244020.64214@mail.fig.ol.no> <20140806210759.GM1228@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------010804040204010005020409 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 06/08/14 23:07, David Wolfskill wrote: > On Wed, Aug 06, 2014 at 10:48:32PM +0200, Trond Endrestøl wrote: >> ... >> Reverting r269510 did the trick, i.e.: >> >> cd /usr/src && svn up && svn diff -r 269510:269509 | patch >> >> My i386 head VM is running smoothly with r269641M, with M meaning only >> the above reversal. >> ... > > Works for me, as well -- thanks! > > FreeBSD 11.0-CURRENT #1333 r269622M/269622:1100028: Wed Aug 6 14:01:30 PDT 2014 > > (I'll be providing more details to royger@ et al. in a moment.) I think I've found the issue, but since I'm not able to reproduce it, could someone try the following patch? (without r269510 reverted). Thanks, Roger. --------------010804040204010005020409 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-atpic-make-sure-atpic_init-is-called-after-IO-APIC-i.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-atpic-make-sure-atpic_init-is-called-after-IO-APIC-i.pa"; filename*1="tch" >From 91264290520a6a6eee6cd35d05a65e2dd0e61dc8 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne <roger.pau@citrix.com> Date: Thu, 7 Aug 2014 12:05:10 +0200 Subject: [PATCH] atpic: make sure atpic_init is called after IO APIC initialization After r269510 the IO APIC and ATPIC initialization is done at the same order, which means atpic_init can be called before the IO APIC has been initalized. In that case the ATPIC will take over the interrupt sources, preventing the IO APIC from registering them. Reported by: David Wolfskill <david@catwhisker.org> Sponsored by: Citrix Systems R&D --- sys/x86/isa/atpic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sys/x86/isa/atpic.c b/sys/x86/isa/atpic.c index 6ce6d1a..e3fdb34 100644 --- a/sys/x86/isa/atpic.c +++ b/sys/x86/isa/atpic.c @@ -524,7 +524,7 @@ atpic_init(void *dummy __unused) intr_register_source(&ai->at_intsrc); } } -SYSINIT(atpic_init, SI_SUB_INTR, SI_ORDER_SECOND + 1, atpic_init, NULL); +SYSINIT(atpic_init, SI_SUB_INTR, SI_ORDER_FOURTH, atpic_init, NULL); void atpic_handle_intr(u_int vector, struct trapframe *frame) -- 1.7.7.5 (Apple Git-26) --------------010804040204010005020409--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53E363DD.4040105>