Date: Fri, 6 Oct 2000 14:11:26 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: current@freebsd.org Subject: Re: panic in ufs_extattr_uepm_destroy() Message-ID: <Pine.NEB.3.96L.1001006141000.65844D-100000@fledge.watson.org> In-Reply-To: <20001006104343.A49423@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 6 Oct 2000, David O'Brien wrote: > This has a KNF style problem. The line you remove should stay and > "ump = VFSTOUFS(mp);" added. Well, either way, it has to be moved further up in the function or you dereference the NULL pointer. Bruce also pointed out the style problem, and I'll commit a fix to that this evening when I'm backin in Massachusetts. I should point out that the reason I modified it the way I did was to make it consistent witth use of VFSTOUFS in many other locations in the UFS/FFS code. Robert N M Watson robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1001006141000.65844D-100000>