Date: Tue, 14 Sep 2004 06:43:46 +0000 (UTC) From: Don Lewis <truckman@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/sound/pcm sndstat.c Message-ID: <200409140643.i8E6hlXx006032@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
truckman 2004-09-14 06:43:46 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_5)
sys/dev/sound/pcm sndstat.c
Log:
MFC sndstat.c 1.18
> Convert sndstat_lock from a mutex to an sx lock. sndstat_read()
> holds sndstat_lock across a call to uiomove(), which is not legal
> to do with a mutex because of the possibility that the data transfer
> could sleep because of a page fault. It is not possible to just
> unlock the mutex for the uiomove() call without introducing another
> locking mechanism to prevent the body of sndstat_read() from being
> re-entered. Converting sndstat_lock to an sx lock is the least
> complicated change.
LOR: 030
Approved by: re (scottl)
Revision Changes Path
1.17.2.1 +29 -26 src/sys/dev/sound/pcm/sndstat.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409140643.i8E6hlXx006032>