Date: Sun, 21 Jun 2009 17:56:17 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Michael <freebsdusb@bindone.de> Cc: freebsd-acpi@freebsd.org Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp Message-ID: <AA3A7A26-E86D-4B04-91E2-826FA4D46BE0@freebsd.org> In-Reply-To: <4A3E5F40.4040709@bindone.de> References: <4A3E1784.2050406@bindone.de> <5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org> <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org> <4A3E5F40.4040709@bindone.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Jun 2009, at 17:26, Michael wrote: > Rui Paulo wrote: >> On 21 Jun 2009, at 15:08, Rui Paulo wrote: >> >>> On 21 Jun 2009, at 12:20, Michael wrote: >>> >>>> Hello, >>>> >>>> I wrote two new acpi modules last year and finally found the time >>>> to fix >>>> them, add some missing features and write man pages. >>> >>> Michael, this is great work! I'll review and see if we can ship it >>> with 8.0! >> >> Michael, this looks good, but there are two style nits that we need >> to fix. >> * we should try not going over the 80 column mark >> * add a empty new line before every return >> >> If you could send me a new patch for 8.0 with these fixes, I'll >> commit >> it (unless someone else has objections). >> >> Regards, >> -- >> Rui Paulo >> > > Hi Rui, > > hmm style(9) doesn't say anything about columns or return statements > in > this context (maybe it should be updated?!?). I've been looking again at style(9) and seems like I'm misremembering something. Please ignore this request and sorry for the hassle. -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AA3A7A26-E86D-4B04-91E2-826FA4D46BE0>