Date: Mon, 11 Jun 2007 23:45:35 -0400 From: Rob Austein <sra@hactrn.net> To: multimedia@FreeBSD.org Subject: multimedia/tovid bug (and patch) Message-ID: <20070612034536.5371222828@thrintun.hactrn.net>
next in thread | raw e-mail | index | archive | help
Environment: FreeBSD thrintun.hactrn.net 6.2-STABLE FreeBSD 6.2-STABLE #26: Sat May 19 09:04:40 EDT 2007 sra@thrintun.hactrn.net:/usr/obj/usr/src/sys/THRINTUN i386 GNU bash, version 3.1.17(0)-release (i386-portbld-freebsd6.1) Symptom: After running makemenu, makexml, and makedvd, dvdauthor quits with a complaint about not being able to find a seventh button in the DVD menu I created, which is odd since I only asked for six buttons. Analysis: Bad shell quoting in a test command results in makemenu adding a "Back" button that neither I nor makexml knew about, so dvdauthor was right to complain. Patch: --- src/makemenu.sh.~1~ Sun Dec 18 14:05:53 2005 +++ src/makemenu.sh Mon Jun 11 23:03:45 2007 @@ -315,7 +315,7 @@ # Use a foreground canvas the size of the background minus safe area -if [[ -n $SAFE_AREA ]]; then +if [[ -n "$SAFE_AREA" ]]; then FG_WIDTH=`expr $WIDTH \* 4 \/ 5` FG_HEIGHT=`expr $HEIGHT \* 4 \/ 5` else @@ -377,7 +377,7 @@ done # If there was a "back", add it at the end -if [[ -n $BACK_BUTTON ]]; then +if [[ -n "$BACK_BUTTON" ]]; then # Leave an empty line CUR_Y=$NEXT_Y NEXT_Y=`expr $NEXT_Y \+ $TITLE_SPACING`
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070612034536.5371222828>