Date: Sat, 3 Apr 2004 15:33:28 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Lukas Ertl <le@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs Makefile Message-ID: <20040403233328.GA34996@dhcp01.pn.xcllnt.net> In-Reply-To: <20040404010004.M9970@leelou.in.tern> References: <200404032226.i33MQhSf088122@repoman.freebsd.org> <20040403225124.GB34949@dhcp01.pn.xcllnt.net> <20040404010004.M9970@leelou.in.tern>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 04, 2004 at 01:02:09AM +0200, Lukas Ertl wrote:
> On Sat, 3 Apr 2004, Marcel Moolenaar wrote:
>
> > On Sat, Apr 03, 2004 at 02:26:43PM -0800, Lukas Ertl wrote:
> > > le 2004/04/03 14:26:43 PST
> > >
> > > FreeBSD src repository
> > >
> > > Modified files:
> > > sbin/growfs Makefile
> > > Log:
> > > Temporarily go back to WARNS=0 until I can figure out what's breaking
> > > the {powerpc, sparc64, ia64} tinderboxes.
> >
> > The problem is in sys/ufs/ffs/fs.h. I think if you change
> > ((int32_t *)((u_int8_t *)(cgp) + (cgp)->cg_xxx))
> > to
> > ((int32_t *)((uintptr_t)(cgp) + (cgp)->cg_xxx))
> >
> > for the definitions of cg_inosused(), cg_blksfree(), cg_clustersfree()
> > and cg_clustersum() you should be ok. I haven't tested it...
>
> Apart from growfs, the cg_clustersum() macro is used in newfs, fsck_ffs,
> and dumpfs, AFAICS. They all are compiled with WARNS=2....
Nonetheless, the change does actually remove most of the alignment
warnings. I have no idea what's different in newfs or others. JFYI,
--
Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040403233328.GA34996>