Date: Fri, 5 Jul 2013 16:21:44 +0000 (UTC) From: Devin Teske <dteske@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r252797 - head/usr.sbin/sysrc Message-ID: <201307051621.r65GLiNl092851@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dteske Date: Fri Jul 5 16:21:44 2013 New Revision: 252797 URL: http://svnweb.freebsd.org/changeset/base/252797 Log: Do not inherit $SYSRC_VERBOSE from operating environment. The concern is that when a user (such as myself) which has SYSRC_VERBOSE=1 in his/her ~/.bash_profile or such that when they are told to execute a command like: hostname `sysrc -n hostname` NOTE: To activate a recently configured hostname. If $SYSRC_VERBOSE is set, then POLA is violated because the output of sysrc is indirectly influenced (making for an inconsistent experience). Modified: head/usr.sbin/sysrc/sysrc Modified: head/usr.sbin/sysrc/sysrc ============================================================================== --- head/usr.sbin/sysrc/sysrc Fri Jul 5 16:03:19 2013 (r252796) +++ head/usr.sbin/sysrc/sysrc Fri Jul 5 16:21:44 2013 (r252797) @@ -1,6 +1,6 @@ #!/bin/sh #- -# Copyright (c) 2010-2012 Devin Teske +# Copyright (c) 2010-2013 Devin Teske # All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -32,13 +32,6 @@ BSDCFG_SHARE="/usr/share/bsdconfig" [ "$_COMMON_SUBR" ] || . $BSDCFG_SHARE/common.subr || exit 1 [ "$_SYSRC_SUBR" ] || f_include $BSDCFG_SHARE/sysrc.subr -############################################################ CONFIGURATION - -# -# Default verbosity. -# -: ${SYSRC_VERBOSE:=} - ############################################################ GLOBALS # @@ -55,6 +48,7 @@ SHOW_EQUALS= SHOW_FILE= SHOW_NAME=1 SHOW_VALUE=1 +SYSRC_VERBOSE= ############################################################ FUNCTIONS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307051621.r65GLiNl092851>