Date: Mon, 21 Jul 2014 11:07:18 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, owner-src-committers@freebsd.org Subject: Re: svn commit: r268494 - in head: lib/libsbuf sys/kern sys/sys Message-ID: <20140721090718.GC51328@ptrcrt.ch> In-Reply-To: <f964663ce71f8554198c1a8fc2ccda60@shatow.net> References: <201407101308.s6AD8pbR080041@svn.freebsd.org> <f964663ce71f8554198c1a8fc2ccda60@shatow.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2014-Jul-18, 18:47, Bryan Drewery wrote: > On 2014-07-10 08:08, Pietro Cerutti wrote: > > Author: gahr (ports committer) > > Date: Thu Jul 10 13:08:51 2014 > > New Revision: 268494 > > URL: http://svnweb.freebsd.org/changeset/base/268494 > > > > Log: > > Implement Short/Small String Optimization in SBUF(9) and change > > lengths and > > positions in the API from ssize_t and int to size_t. > > > > CR: D388 > > Approved by: des, bapt > > > > Modified: > > head/lib/libsbuf/Makefile > > head/sys/kern/subr_sbuf.c > > head/sys/sys/sbuf.h > > > > Modified: head/lib/libsbuf/Makefile > > ============================================================================== > > --- head/lib/libsbuf/Makefile Thu Jul 10 13:04:52 2014 (r268493) > > +++ head/lib/libsbuf/Makefile Thu Jul 10 13:08:51 2014 (r268494) > > @@ -4,7 +4,7 @@ LIB= sbuf > > SHLIBDIR?= /lib > > SRCS= subr_sbuf.c > > > > -SHLIB_MAJOR = 6 > > +SHLIB_MAJOR = 7 > > > > SYMBOL_MAPS= ${.CURDIR}/Symbol.map > > VERSION_DEF= ${.CURDIR}/Version.def > > > > We have symbol versioning in libsbuf. Shouldn't need to bump the > version. Just need to add a compat function for everything. It would be > a lot of work, but bumping for ssize_t->size_t seems gratuitous to me. The bump was due mainly to the addition of the s_static_buf field to the sbuf struct. -- Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJTzNhGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgie0L8P/1ZDdbBcqq5R2LZB2aN5RWxU 77tpZeTzV576p1pkvzvkt+OUlVvBpxrjOA7o+PEmw0w1BzIIS4Mz2OUqNuci/M3K EU/ar1yyQghEknXiS8MW4KfpPJqSbInfnnXv+/i6YTjSVN4SH7ZVMZoucmfub9zI iZSn29ZGhXMgUBvEDyH09uGsyAvOcVcGX0UuZKHXV3VNiYOwz1WvWYhbls9Zky3b 2nG0CM5v+JURJfC3xE13EHkq6gkDSWFbd3SK0psdQOKfRVhTs6n7cKIRdaghIKFo KK+CuVQJKI16FRDex3bh4zZgpAu/iTvRpxBQsx/IL9WUEIL7rChDgvFQ+ok9aDCB 9iteikJqK40NQyM/LgfYdPgFENYKgti3+sxbwBOvRvu183FQrTdPhC/1uiE07zrp AUAG/vUAWCR/5l4qYjrjIfgz+LkCap7d2WdddLQEiY39LwqVHipe1S5afhg3kFoh cDmC4KYX9GGvzuPpqb4jroyDD0zoeFLfcspkTXfr03kRN27E82IQrLFbVq/6IOHj 3qzasU0B0c4kHHJtrTEJYCSmIlb/GcK0QRsPQ/VIJhe6ttGnov9KLrnmdeunvfM6 v4aaKFOUhxYGuzn5C5RPcGuXXAHa7NL/hg619HGKWMk4W1P7Wf0AhBJyp9KWtAgm xb6WQspUNRbkn6NcmZ2Y =DXz8 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140721090718.GC51328>