Date: Wed, 18 Feb 2009 19:59:27 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/contrib/bsnmp/snmp_mibII mibII.c Message-ID: <200902181959.n1IJxbBA006529@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2009-02-18 19:59:27 UTC FreeBSD src repository Modified files: contrib/bsnmp/snmp_mibII mibII.c Log: SVN rev 188760 on 2009-02-18 19:59:27Z by imp Add an extra (void *) cast. The struct if_msghdr has an 8 byte alignment requirement, while rt_msghdr has a 4 byte alignment requirement. The root cause is that if_msghdr has an struct if_data which has an 8-byte alignment requirement due to a time_t that's embedded in it. On MIPS, time_t is a 64-bit number, so must be 64-bit aligned. Since we don't access ifm_data.ifi_epoch, a simple cast is all that's necessary here. It is likely the case that ifi_epoch should *NOT* be a time_t because it is an uptime (time delta) an not an absolute time since 1970. u_long is likely sufficient there since that gives an uptime of 136 years will suffice for the foreseeable future. Revision Changes Path 1.3 +1 -1 src/contrib/bsnmp/snmp_mibII/mibII.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902181959.n1IJxbBA006529>