Date: Mon, 2 Jul 2018 09:30:31 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: steven.hartland@multiplay.co.uk, Matt Macy <mmacy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335856 - in head/sys: netinet sys Message-ID: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < > steven.hartland@multiplay.co.uk> wrote: > > > > You have M_WAITOK and a null check in this change > > And, that's the same as the way it was before his commits. So, he did > exactly what he said he was doing and reverted his commits. I don't think > it is good practice to mix reverts with other changes. It is a very bad practive to mix a revert with anything. > Since you've noticed this, I think you should feel free to make the change. > Jonathan -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807021630.w62GUVEQ034521>