Date: Wed, 2 Apr 2014 18:24:25 -0700 From: hiren panchasara <hiren.panchasara@gmail.com> To: Midori Kato <katoon@sfc.wide.ad.jp> Cc: "Eggert, Lars" <lars@netapp.com>, "freebsd-net@freebsd.org" <net@freebsd.org> Subject: Re: DCTCP implementation Message-ID: <CALCpEUHvD3iUw3FjUL8NNm60nFG9DGmrp4iojRszGD4f2PhgLQ@mail.gmail.com> In-Reply-To: <5338FF05.1020302@sfc.wide.ad.jp> References: <5338FF05.1020302@sfc.wide.ad.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 30, 2014 at 10:37 PM, Midori Kato <katoon@sfc.wide.ad.jp> wrote: > Hi FreeBSD developpers, > > I'm Midori Kato. I'm working on the DCTCP implementation in the FreeBSD with > Lars Eggert. I mail you because I would like to ask you a code review and > testing. The attached patch is not good enough to test our code. Please give > me your message. I will send an ECN marking implmenetation in dummynet and > test scripts personally to you. Midori, First thing I noticed in your dctcp.patch is that you are dropping r256920 which adds a new argument tlen to DELAY_ACK() macro. I also see you removed and re-added that macro definition without any changes to it. Is that intentional? If not, can you please fix that and resend the patch? It is usually a good idea to work on -HEAD for such things so patching/committing is easier. cheers, Hiren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALCpEUHvD3iUw3FjUL8NNm60nFG9DGmrp4iojRszGD4f2PhgLQ>