Date: Thu, 19 May 2016 11:19:37 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r300201 - head/sys/sys Message-ID: <201605191119.u4JBJb9f027906@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Thu May 19 11:19:37 2016 New Revision: 300201 URL: https://svnweb.freebsd.org/changeset/base/300201 Log: Add ta_flags initialization in old macros missed in 300113. Depending on uninitialized memory content it could cause loss of wakeup() call in taskqueue_run_locked(). Modified: head/sys/sys/taskqueue.h Modified: head/sys/sys/taskqueue.h ============================================================================== --- head/sys/sys/taskqueue.h Thu May 19 11:02:39 2016 (r300200) +++ head/sys/sys/taskqueue.h Thu May 19 11:19:37 2016 (r300201) @@ -97,6 +97,7 @@ void taskqueue_set_callback(struct taskq #define TASK_INITIALIZER(priority, func, context) \ { .ta_pending = 0, \ + .ta_flags = 0, \ .ta_priority = (priority), \ .ta_func = (func), \ .ta_context = (context) } @@ -112,6 +113,7 @@ void taskqueue_thread_enqueue(void *cont */ #define TASK_INIT(task, priority, func, context) do { \ (task)->ta_pending = 0; \ + (task)->ta_flags = 0; \ (task)->ta_priority = (priority); \ (task)->ta_func = (func); \ (task)->ta_context = (context); \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605191119.u4JBJb9f027906>