Date: Thu, 21 Apr 2016 23:40:28 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298459 - head/sys/ofed/drivers/infiniband/core Message-ID: <ACFD05F8-54A2-4082-9C28-1FB62EC31A3C@gmail.com> In-Reply-To: <201604220639.u3M6d8vF010061@repo.freebsd.org> References: <201604220639.u3M6d8vF010061@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 21, 2016, at 23:39, Hans Petter Selasky <hselasky@FreeBSD.org> wrote: > > Author: hselasky > Date: Fri Apr 22 06:39:07 2016 > New Revision: 298459 > URL: https://svnweb.freebsd.org/changeset/base/298459 > > Log: > Add KASSERT() and set error code in dead code case to help static code > analysis tools. > > Suggested by: ngie@ > Sponsored by: Mellanox Technologies > MFC after: 1 week > > Modified: > head/sys/ofed/drivers/infiniband/core/addr.c > > Modified: head/sys/ofed/drivers/infiniband/core/addr.c > ============================================================================== > --- head/sys/ofed/drivers/infiniband/core/addr.c Fri Apr 22 06:33:06 2016 (r298458) > +++ head/sys/ofed/drivers/infiniband/core/addr.c Fri Apr 22 06:39:07 2016 (r298459) > @@ -404,6 +404,8 @@ mcast: > break; > #endif > default: > + KASSERT(0, ("rdma_addr_resolve: Unreachable")); > + error = EINVAL; > break; > } > RTFREE(rte); Thanks :)!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACFD05F8-54A2-4082-9C28-1FB62EC31A3C>