Date: Sun, 28 Oct 2012 01:59:07 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Rui Paulo <rpaulo@felyko.com> Cc: svn-src-head@FreeBSD.org, Adrian Chadd <adrian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys Message-ID: <20121027215907.GI70741@FreeBSD.org> In-Reply-To: <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com> References: <201210161337.q9GDbtr8049924@svn.freebsd.org> <CAJ-Vmon8BxdbTUsOXF7kCOqO3=GuKXaHFqOqGHoGgmGV2=%2B6aw@mail.gmail.com> <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 26, 2012 at 09:16:08PM -0700, Rui Paulo wrote: R> I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking stack). This is against all reasonable software development practices. - This wasn't discussed privately but on svn-src-head@ mailing list. You could participate. - No objections were raised one year ago. The code of if_cloners hasn't any single change during this year. - If you mean that brooks@ is not very active in networking stack, then I will point your attention to the fact that he is the original author of interface cloners. Now my questions: - Do we have any policy that doesn't permit changing ABI in head? - Apart from the ABI is there anything wrong with the r241610? P.S. And yes, please don't use top-quoting on FreeBSD mailing lists: http://www.freebsd.org/doc/en/articles/mailing-list-faq/etiquette.html -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121027215907.GI70741>