Date: Wed, 23 Jan 2013 14:29:28 -0700 From: "Justin T. Gibbs" <gibbs@freebsd.org> To: Alexander Motin <mav@freebsd.org> Cc: Jaakko Heinonen <jh@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, freebsd-current@freebsd.org, Vitalij Satanivskij <satan@ukr.net> Subject: Re: panic after r244584 Message-ID: <E98D9AFF-304D-429D-8904-EA744D4AD06A@freebsd.org> In-Reply-To: <51004A69.6020809@FreeBSD.org> References: <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <50F94D80.7000809@FreeBSD.org> <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi> <20130121154400.GA1808@a91-153-116-96.elisa-laajakaista.fi> <20130121173122.GA20466@hell.ukr.net> <20130123071346.GA56937@hell.ukr.net> <20130123195104.GA1802@a91-153-116-96.elisa-laajakaista.fi> <51004A69.6020809@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 23, 2013, at 1:39 PM, Alexander Motin <mav@FreeBSD.org> wrote: > On 23.01.2013 21:51, Jaakko Heinonen wrote: >> On 2013-01-23, Vitalij Satanivskij wrote: >>> VS> Jaakko Heinonen wrote: >>> VS> JH> > I see two possible solutions for the problem. >>> VS> JH> >=20 >>> VS> JH> > 1) Replace non-printable, space and '/' characters for = example with '_'. >>> VS> JH> > '/' should be replaced anyway. >>> VS> JH> >=20 >>> VS> JH> > 2) Apply the patches in >>> VS> JH> > = http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html >>> VS> JH> > to allow spaces again. I haven't committed the patches = because I >>> VS> JH> > think that there isn't full consensus that it's right = thing to do and >>> VS> JH> > also I personally prefer not to have spaces in device = names. >>> VS> JH>=20 >>> VS> JH> Here's a patch to implement 1: >>> VS> JH>=20 >>> VS> JH> = http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff >>> VS>=20 >>> VS> Ok that patch work's too. >>>=20 >>> Is there any chance, that one of this patches will be merged to = head?=20 >>=20 >> Yes. >>=20 >> Alexander and Justin: what do you think about this patch? >>=20 >> http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff >=20 > It is fine for me, or at least better then panic. But that is Justin's > code, so he should know better. It's fine. -- Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E98D9AFF-304D-429D-8904-EA744D4AD06A>