Date: Mon, 11 Jan 2016 11:36:05 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Ravi Pokala <rpokala@mac.com>, Allan Jude <allanjude@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292788 - in head/sys: geom/part sys Message-ID: <56936975.9000202@yandex.ru> In-Reply-To: <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11.01.16 07:54, Ravi Pokala wrote: > In that review, there was discussion about the sorting of aliases in (enum g_part_alias). It was originally thought that the aliases needed to be sorted, due to binary searching in g_part_alias_name(). It turned out that g_part_alias_name() did a linear search, so the list didn't strictly need to be sorted. But, there was talk of potentially switching to a binary search later, so Allan went with the sorted version. Hi, no, my note was relate to the following possible problem: you have some stable/10 and some geom_part_panasas module installed from the ports in the /boot/modules. When you rebuild the kernel after merging r292788 your module will use old values of g_part_alias and thus it will get not the same aliases. You will need rebuild your module to fix this. -- WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56936975.9000202>