Date: Fri, 25 Aug 2017 06:15:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 220698] [iflib][em] some interface options flags can not change Message-ID: <bug-220698-8-QSQ8TigVtx@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220698-8@https.bugs.freebsd.org/bugzilla/> References: <bug-220698-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220698 --- Comment #1 from Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> --- Created attachment 185741 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185741&action= =3Dedit make vlan_hwcsum and wol flags changeable This patch makes only vlan_hwcsum and wol flags changeable. 1st chunk: I think that IFCAP_FLAGS defines changeable flags in general. In if.h, IFCAP_RXCSUM_IPV6 | IFCAP_TXCSUM_IPV6 is IFCAP_HWCSUM_IPV6, and IFCAP_TSO4 | IFCAP_TSO6 is IFCAP_TSO. Change these flags for simplifyin= g. Add missing flags IFCAP_WOL_MCAST (contained by IFCAP_WOL) and IFCAP_VLAN_HWCSUM. IFCAP_HWSTATS should be removed because it is not changeable flags, but it stays in the patch now. 2nd chunk: Change from (IFCAP_TOE4 | IFCAP_TOE6) to IFCAP_TOE defined in if.h. Delete WOL related lines. "setmask |=3D (mask & IFCAP_FLAGS);" has same functionality, if IFCAP_FLAGS has IFCAP_WOL added by 1st chunk. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220698-8-QSQ8TigVtx>