Date: Fri, 8 Jan 2021 23:38:10 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 20ac5cda965e - main - fd: make fd/fp mandatory Message-ID: <CAGudoHH1LQiFJv4Y4Win9FSGGOU-9PDq%2BzOAnx7T0JF5ZzpOcg@mail.gmail.com> In-Reply-To: <252b68ff-3021-470f-3bc7-c6c809fa4958@FreeBSD.org> References: <202101072330.107NUM8u075841@gitrepo.freebsd.org> <252b68ff-3021-470f-3bc7-c6c809fa4958@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
It definitely should have stated +/-: fd: make fd/fp mandatory in falloc I don't know how I dropped that part, it was reshuffled from a bigger patchset. On 1/8/21, John Baldwin <jhb@freebsd.org> wrote: > On 1/7/21 3:30 PM, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=20ac5cda965eccc34f975674c6efc97c3615a234 >> >> commit 20ac5cda965eccc34f975674c6efc97c3615a234 >> Author: Mateusz Guzik <mjg@FreeBSD.org> >> AuthorDate: 2020-12-23 13:50:34 +0000 >> Commit: Mateusz Guzik <mjg@FreeBSD.org> >> CommitDate: 2021-01-07 23:30:04 +0000 >> >> fd: make fd/fp mandatory >> >> They are both always passed anyway. > > Perhaps say which part of the API this affects (seems to be falloc*() from > the diff?) next time? As it reads now, the log implies it applies to all > functions in the file descriptor API which can't possibly be true (fdrop > doesn't take 'fd' for example). > > -- > John Baldwin > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHH1LQiFJv4Y4Win9FSGGOU-9PDq%2BzOAnx7T0JF5ZzpOcg>