Date: Sun, 30 Dec 2001 15:54:23 +0200 From: Sheldon Hearn <sheldonh@starjuice.net> To: Maxim Konovalov <maxim@macomnet.ru> Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>, current@FreeBSD.ORG, chad@FreeBSD.ORG Subject: Re: Junior Kernel Hacker Task: ccdinit stack usage. Message-ID: <89995.1009720463@axl.seasidesoftware.co.za> In-Reply-To: Your message of "Sun, 30 Dec 2001 16:45:31 %2B0300." <20011230160821.L36208-100000@news1.macomnet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 30 Dec 2001 16:45:31 +0300, Maxim Konovalov wrote: > struct partinfo holds only two pointers, ccg is a pointer too. I got confused with partinfo and disklabel, and didn't actually check ccg. *blush* > > Note that you don't need to (and shouldn't as per style(9)) initialize > > tmppath to NULL. > > Do you mean: > > : Be careful to not obfuscate the code by initializing variables > : in the declarations. Use this feature only thoughtfully. DO NOT > : use function calls in initializers. > > or something else? Yes, that. Bruce Evans will probably want tmppath initialized to NULL near the top of the function's code, rather than in the declarations. :-) > man 9 malloc: > > : A type is defined using the malloc_type_t typedef via the > : MALLOC_DECLARE() and MALLOC_DEFINE() macros. > > Take a look at /usr/src/sys/sys/malloc.h. That only tells me where it comes from, not when I'd want to use it. :-) > What about this one: It's probably worth giving Poul-Henning time to wake up. ;-) Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?89995.1009720463>