Date: Sun, 4 Jun 2017 16:47:24 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs Message-ID: <721fdeb3-b9d6-b8f4-9025-a5ae7bfd295f@FreeBSD.org> In-Reply-To: <CAPyFy2BZR62MtuckgrC6crRNDgbfMDvd0d5mjONHpxbCgqTxxg@mail.gmail.com> References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> <CAPyFy2BZR62MtuckgrC6crRNDgbfMDvd0d5mjONHpxbCgqTxxg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2 Content-Type: multipart/mixed; boundary="1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <721fdeb3-b9d6-b8f4-9025-a5ae7bfd295f@FreeBSD.org> Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> <CAPyFy2BZR62MtuckgrC6crRNDgbfMDvd0d5mjONHpxbCgqTxxg@mail.gmail.com> In-Reply-To: <CAPyFy2BZR62MtuckgrC6crRNDgbfMDvd0d5mjONHpxbCgqTxxg@mail.gmail.com> --1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/4/17 4:27 PM, Ed Maste wrote: > On 4 June 2017 at 14:06, Bryan Drewery <bdrewery@freebsd.org> wrote: >> >> In r189170. It seems to me we should change systm.h back to a macro >> #define memmove(dst, src, len) bcopy((src), (dst), (len)) >=20 > Note that they're not quite equivalent: memmove returns dst, while > bcopy has no return value. >=20 #define memmove(dst, src, len) (bcopy((src), (dst), (len)), dst) Obscure comma operator, or we just add an inline memmove in systm.h too. --=20 Regards, Bryan Drewery --1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3-- --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJZNJwNAAoJEDXXcbtuRpfPv7sH/3Iq4Fa5ov9NOQrZ6LbWEt4E cDdnl0CnS1qvkIwnuT4W+0Qiw+jd27E8N85oPMX4tPNnJTqC/d0IBFOcXKbFCNLg OQ/BMeCELonEs2MnK7enKI4QAiaVYQrhJu+cVyLrhuu/jkdodCWmoIf8K/jpNwoU 40CxNplBjaFk5twlI8jYYe1mxkqtVvvtcZ+D8jUBPmjMOThRP+G2U8jBBdtKsBBL r06mlGQin8+lquAlASxH7JpRWkxeUvjrjGVhaQmTYqPltTlxr025O+OinFt2JgeS wPVlXWXGCgX+L4sicd1ooLtRBJ5gxLjXxLapJilelZHWARLiQO3uatzUGn/BGtQ= =3JMT -----END PGP SIGNATURE----- --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?721fdeb3-b9d6-b8f4-9025-a5ae7bfd295f>