Date: Tue, 1 Jun 2010 19:56:02 +0000 (UTC) From: Alan Cox <alc@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r208720 - head/sys/powerpc/booke Message-ID: <201006011956.o51Ju2XE029719@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: alc Date: Tue Jun 1 19:56:02 2010 New Revision: 208720 URL: http://svn.freebsd.org/changeset/base/208720 Log: In the case that mmu_booke_enter_locked() is changing the attributes of a mapping but not changing the physical page being mapped, the wrong flags were being inspected in order to determine whether or not to flush the instruction cache. The effect of looking at the wrong flags was that the instruction cache was never being flushed. Reviewed by: marcel Modified: head/sys/powerpc/booke/pmap.c Modified: head/sys/powerpc/booke/pmap.c ============================================================================== --- head/sys/powerpc/booke/pmap.c Tue Jun 1 19:39:27 2010 (r208719) +++ head/sys/powerpc/booke/pmap.c Tue Jun 1 19:56:02 2010 (r208720) @@ -1621,7 +1621,7 @@ mmu_booke_enter_locked(mmu_t mmu, pmap_t * are turning execute permissions on, icache should * be flushed. */ - if ((flags & (PTE_UX | PTE_SX)) == 0) + if ((pte->flags & (PTE_UX | PTE_SX)) == 0) sync++; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006011956.o51Ju2XE029719>