Date: Mon, 2 Oct 2000 23:54:29 -0400 (EDT) From: "Matthew N. Dodd" <winter@jurai.net> To: Takahashi Yoshihiro <nyan@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall devices.c src/sys/conf files.pc98 src/sys/dev/snc dp83932.c dp83932reg.h dp83932subr.c dp83932subr.h dp83932var.h if_snc.c if_snc_cbus.c if_snc_pccard.c if_sncreg.h if_sncvar.h src/sys/modules Makefile ... Message-ID: <Pine.BSF.4.21.0010022351060.1566-100000@sasami.jurai.net> In-Reply-To: <200010021427.HAA16733@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2 Oct 2000, Takahashi Yoshihiro wrote:
> Added NEC PC-9801-83, 84, PC-9801-103, 104, PC-9801N-25 and PC-9801N-J02R
> support which use National Semiconductor DP8393X (SONIC) as ethernet
> controller. Currently, this driver is used on only PC-98.
if_sn.c:snc_alloc_{port,memory,irq}() all need fixing in their handling of
the failure case of bus_alloc_resource(). You can't rely on
bus_get_resource()/bus_get_resource_start() to do the right thing if
bus_alloc_resource() has already failed. You -must- check the return of
bus_get_resource()/bus_get_resource_start().
I'd suggest punting as the failure case only prints out a cosmetic "this
didn't work" message.
--
| Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD |
| winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax |
| http://www.jurai.net/~winter | This Space For Rent | ISO8802.5 4ever |
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0010022351060.1566-100000>