Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Oct 2012 09:43:38 -0700
From:      Neel Natu <neelnatu@gmail.com>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Neel Natu <neel@freebsd.org>
Subject:   Re: svn commit: r242170 - projects/bhyve/usr.sbin/bhyve
Message-ID:  <4F77FDF1-BA5A-4D9D-9AD6-0812FB027315@gmail.com>
In-Reply-To: <CAF6rxg=6%2Bh4RNtaSPGt9NwJw2hn2W3FnJBKOG=qHmKDh6ZorLg@mail.gmail.com>
References:  <201210270239.q9R2d8Kv064997@svn.freebsd.org> <CAF6rxg=6%2Bh4RNtaSPGt9NwJw2hn2W3FnJBKOG=qHmKDh6ZorLg@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

Hi Eitan,

On Oct 27, 2012, at 8:52 AM, Eitan Adler <eadler@freebsd.org> wrote:

> On 26 October 2012 22:39, Neel Natu <neel@freebsd.org> wrote:
>> Author: neel
>> Date: Sat Oct 27 02:39:08 2012
>> New Revision: 242170
>> URL: http://svn.freebsd.org/changeset/base/242170
>> 
>> Log:
>>  Ignore PCI configuration accesses to all bus numbers other than PCI bus 0.
> 
> I'm sorry this is a silly question, but why?
> 

At the moment all the emulated PCI devices are on bus 0.

We don't present a PCI device tree hierarchy to the guest with bridges and end-point devices,  so everything hangs off bus 0.

Prior to this change any access to a PCI bus != 0 got aliased to devices on bus 0 which is obviously wrong and tripped up drivers like the QPI driver which start probing backwards from bus 255.

Best
Neel

> 
> -- 
> Eitan Adler
> Source, Ports, Doc committer
> Bugmeister, Ports Security teams


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F77FDF1-BA5A-4D9D-9AD6-0812FB027315>