Date: Wed, 5 Apr 2023 18:59:15 +0200 From: Moin Rahman <bofh@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Message-ID: <C6B9985A-B836-405E-9ED8-E0DDF4D85EFC@freebsd.org> In-Reply-To: <ZC2YSAqMmDW%2BgJF%2B@FreeBSD.org> References: <202304041811.334IB93k074119@gitrepo.freebsd.org> <ZC2YSAqMmDW%2BgJF%2B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <danfe@FreeBSD.org> = wrote: >=20 > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman = wrote: >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 >>=20 >> Refactor java/openjdk7 removal >>=20 >> - Since the introduction of jdk version 18 it looks like similar = with >> jdk version 8(java version string 1.8). This is prone to error as = it >> looks similar and is only seperated by a '.'. Remove using >> JAVA_VERSION with dotted fomat of java version string and update = all >> consumers to utilize version 8 instead of 1.8. >>=20 >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR=3D yes >>=20 >> USES=3D zip:infozip >> USE_JAVA=3D yes >> -JAVA_VERSION=3D 1.8+ >> +JAVA_VERSION=3D 8+ >=20 > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions = similar > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. >=20 > ./danfe You speak my mind; but one step at a time. That is planned in step 2 and = in step 3 I am going to convert this into USES=3Djava. Kind regards, Moin= --Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev <<a = href=3D"mailto:danfe@FreeBSD.org" class=3D"">danfe@FreeBSD.org</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = class=3D"">On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur = Rahman wrote:<br class=3D""><blockquote type=3D"cite" class=3D"">commit = 4cda17ab14588e6e4fdac7f697e246554ce82af3<br class=3D""><br class=3D""> = Refactor java/openjdk7 removal<br class=3D""><br class=3D""> = - Since the introduction of jdk version 18 it looks like similar = with<br class=3D""> jdk version 8(java version string = 1.8). This is prone to error as it<br class=3D""> = looks similar and is only seperated by a '.'. Remove = using<br class=3D""> JAVA_VERSION with dotted fomat of = java version string and update all<br class=3D""> = consumers to utilize version 8 instead of 1.8.<br = class=3D""><br class=3D"">@@ -17,7 +17,7 @@ NO_WRKSUBDIR=3D<span = class=3D"Apple-tab-span" style=3D"white-space:pre"> </span>yes<br = class=3D""><br class=3D""> USES=3D<span class=3D"Apple-tab-span" = style=3D"white-space:pre"> </span><span class=3D"Apple-tab-span" = style=3D"white-space:pre"> </span>zip:infozip<br class=3D""> = USE_JAVA=3D<span class=3D"Apple-tab-span" style=3D"white-space:pre"> = </span>yes<br class=3D"">-JAVA_VERSION=3D<span class=3D"Apple-tab-span" = style=3D"white-space:pre"> </span>1.8+<br = class=3D"">+JAVA_VERSION=3D<span class=3D"Apple-tab-span" = style=3D"white-space:pre"> </span>8+<br class=3D""></blockquote><br = class=3D"">Perhaps we should drop JAVA_VERSION as USE_JAVA accepts = versions similar<br class=3D"">to USE_GCC; separate JAVA_VERSION is just = a needless cognitive burden.<br class=3D""><br class=3D"">./danfe<br = class=3D""></div></div></blockquote></div><br class=3D""><div = class=3D"">You speak my mind; but one step at a time. That is planned in = step 2 and in step 3 I am going to convert this into = USES=3Djava.</div><div class=3D""><br class=3D""></div><div = class=3D"">Kind regards,</div><div class=3D"">Moin</div></body></html>= --Apple-Mail=_CF25581C-DE0E-479A-B8C9-E65368372BE5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C6B9985A-B836-405E-9ED8-E0DDF4D85EFC>