Date: Sat, 25 Jul 2009 21:06:34 -0400 From: Michael Butler <imb@protected-networks.net> To: Jamie Gritton <jamie@FreeBSD.org> Cc: freebsd-stable <freebsd-stable@FreeBSD.org> Subject: Re: regression with jexec? Message-ID: <4A6BAC1A.5080303@protected-networks.net> In-Reply-To: <4A6B9A60.90302@FreeBSD.org> References: <4A6B0BD3.6040206@protected-networks.net> <4A6B9A60.90302@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jamie Gritton wrote:
> Michael Butler wrote:
>> imb@aaron:/home/imb> sudo jexec 5 tcsh
>> jexec: Unable to parse jail ID.: No such file or directory
>
> The symptom in jexec can be fixed by this little patch:
>
> Index: usr.sbin/jexec/jexec.c
> ===================================================================
> --- usr.sbin/jexec/jexec.c (revision 195879)
> +++ usr.sbin/jexec/jexec.c (working copy)
> @@ -248,6 +248,7 @@
> if (argc < 2)
> usage();
> if (strlen(argv[0]) > 0) {
> + errno = 0;
> jid = (int)strtol(argv[0], NULL, 10);
> if (errno)
> err(1, "Unable to parse jail ID.");
Thanks - this certainly cures the effect.
> But the broader problem is malloc. It's leaving errno set to
> ENOENT when /etc/malloc.conf doesn't exist. This seems like
> wrong behavior to me.
Seems like a POLA violation to me,
imb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkprrBoACgkQQv9rrgRC1JIImwCdG2hjH00hKOzMRUHEqfXwu8FS
O6UAoJL/2iZf/Nz0Pp84q0p+RDkNIM+1
=iBx1
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A6BAC1A.5080303>