Date: Sat, 10 Jan 2026 13:54:00 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, Olivier Certner <olce@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 67599eef01f5 - main - sys/x86/NOTES: Add vt_efifb Message-ID: <CANCZdfpA9SKX=zi77bPy0TNSSuzDXqfj51d3=ArA8UYjotNXHA@mail.gmail.com> In-Reply-To: <c26956ab-b32f-4972-b1a3-2b2ee24153b1@FreeBSD.org> References: <69612e4a.3279b.9f58eba@gitrepo.freebsd.org> <aWG5ZVSaAbMwpH0G@kib.kiev.ua> <c26956ab-b32f-4972-b1a3-2b2ee24153b1@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Jan 10, 2026 at 9:42 AM John Baldwin <jhb@freebsd.org> wrote: > On 1/9/26 21:28, Konstantin Belousov wrote: > > On Fri, Jan 09, 2026 at 04:35:22PM +0000, Olivier Certner wrote: > >> The branch main has been updated by olce: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=67599eef01f5417715f673ec81fc1467917c7a10 > >> > >> commit 67599eef01f5417715f673ec81fc1467917c7a10 > >> Author: Olivier Certner <olce@FreeBSD.org> > >> AuthorDate: 2026-01-09 16:23:59 +0000 > >> Commit: Olivier Certner <olce@FreeBSD.org> > >> CommitDate: 2026-01-09 16:34:56 +0000 > >> > >> sys/x86/NOTES: Add vt_efifb > >> > >> Contrary to what is stated in commit f224591746bd ("Add ASMC_DEBUG > make > >> option"), the various NOTES files should list all available > options. > > No, the f224591746bd commit is correct. GENERIC + LINT should cover all > > options and reverse of them, as much as possible. In other words, LINT > > should be complementary to GENERIC, for most options. > > > > At least this is how bde@ described the intent of LINT, and I think > this is > > a right thing to follow. > > Hmmm, I've always understood it that options that change behavior (like, > say > HZ) should have non-default values in LINT to test the setting of > non-default > options, but that LINT itself should include "all the things" in terms of > coverage, so 'device' statements and 'options' that add in new code like > filesystems should always be in LINT. > That's what I always try to do as well... In addition to documenting what often is an under documented part of the tree. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sat, Jan 10, 2026 at 9:42 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/9/26 21:28, Konstantin Belousov wrote:<br> > On Fri, Jan 09, 2026 at 04:35:22PM +0000, Olivier Certner wrote:<br> >> The branch main has been updated by olce:<br> >><br> >> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=67599eef01f5417715f673ec81fc1467917c7a10" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=67599eef01f5417715f673ec81fc1467917c7a10</a><br>; >><br> >> commit 67599eef01f5417715f673ec81fc1467917c7a10<br> >> Author: Olivier Certner <olce@FreeBSD.org><br> >> AuthorDate: 2026-01-09 16:23:59 +0000<br> >> Commit: Olivier Certner <olce@FreeBSD.org><br> >> CommitDate: 2026-01-09 16:34:56 +0000<br> >><br> >> sys/x86/NOTES: Add vt_efifb<br> >> <br> >> Contrary to what is stated in commit f224591746bd ("Add ASMC_DEBUG make<br> >> option"), the various NOTES files should list all available options.<br> > No, the f224591746bd commit is correct. GENERIC + LINT should cover all<br> > options and reverse of them, as much as possible. In other words, LINT<br> > should be complementary to GENERIC, for most options.<br> > <br> > At least this is how bde@ described the intent of LINT, and I think this is<br> > a right thing to follow.<br> <br> Hmmm, I've always understood it that options that change behavior (like, say<br> HZ) should have non-default values in LINT to test the setting of non-default<br> options, but that LINT itself should include "all the things" in terms of<br> coverage, so 'device' statements and 'options' that add in new code like<br> filesystems should always be in LINT.<br></blockquote><div><br></div><div>That's what I always try to do as well... In addition to documenting what often</div><div>is an under documented part of the tree.</div><div><br></div><div>Warner</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpA9SKX=zi77bPy0TNSSuzDXqfj51d3=ArA8UYjotNXHA>