Date: Sun, 29 Mar 2015 23:45:27 +0100 From: Steven Hartland <steven@multiplay.co.uk> To: Alexander Motin <mav@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r280822 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <55188087.4050601@multiplay.co.uk> In-Reply-To: <5518740A.1050806@FreeBSD.org> References: <201503292028.t2TKSJ9E016958@svn.freebsd.org> <55187240.4050007@freebsd.org> <5518740A.1050806@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29/03/2015 22:52, Alexander Motin wrote: > On 30.03.2015 00:44, Steven Hartland wrote: >> Given the upstream nature of this code it may be better to not do >> cosmetic changes like unless they are first upstreamed as it makes >> comparing with the upstream when bringing update harder. > My changes didn't move the code away from the upstream, may be even made > it a bit closer. In places where upstream code has "64 << 20", I changed > our code from "64<<18" to "16 << 20", which I believe both more correct > and closer to upstream. > Cool thanks for clarifying, sounds like we might need a pass over things to see if we can bring in any other changes which may have slipped though the net.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55188087.4050601>