Date: Sat, 17 Mar 2018 04:29:20 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Ian Lepore <ian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331063 - head/sys/arm/arm Message-ID: <20180317041629.Y23257@besplex.bde.org> In-Reply-To: <201803161606.w2GG6QCJ091704@repo.freebsd.org> References: <201803161606.w2GG6QCJ091704@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Mar 2018, Ian Lepore wrote:
> Log:
> Add the header file needed for the recently-added call to pagedaemon_wakeup().
>
> Modified:
> head/sys/arm/arm/pmap-v4.c
>
> Modified: head/sys/arm/arm/pmap-v4.c
> ==============================================================================
> --- head/sys/arm/arm/pmap-v4.c Fri Mar 16 16:04:06 2018 (r331062)
> +++ head/sys/arm/arm/pmap-v4.c Fri Mar 16 16:06:25 2018 (r331063)
> @@ -168,6 +168,7 @@ __FBSDID("$FreeBSD$");
> #include <vm/vm_page.h>
> #include <vm/vm_pageout.h>
> #include <vm/vm_phys.h>
> +#include <vm/vm_pagequeue.h>
> #include <vm/vm_extern.h>
>
> #include <machine/md_var.h>
It used to be in the correct header (vm/vm_pageout.h).
Another bug in this function is its name. It is missing a vm_ prefix.
It was the only name in vm_pageout.h with this bug (macros there have
a prefix of VM_; variables and functions have a prefix of vm_).
vm_pagequeue.h was almost as clean. It is now polluted by:
- nested include of sys/pidcontrol.h
- prototype for this function
- call to this function.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180317041629.Y23257>