Date: Mon, 24 Sep 2001 13:05:19 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/conf GENERIC src/sys/i386/conf GEN Message-ID: <20010924130519.A25323@dragon.nuxi.com> In-Reply-To: <XFMail.010924123349.jhb@FreeBSD.org>; from jhb@FreeBSD.org on Mon, Sep 24, 2001 at 12:33:49PM -0700 References: <200109240323.f8O3Nmf69956@freefall.freebsd.org> <XFMail.010924123349.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 24, 2001 at 12:33:49PM -0700, John Baldwin wrote:
> > obrien 2001/09/23 20:23:48 PDT
> > Modified files:
> > sys/alpha/conf GENERIC
> > sys/i386/conf GENERIC
> > sys/ia64/conf GENERIC
> > sys/pc98/conf GENERIC
> > sys/sparc64/conf GENERIC
> > Log:
> > + Fix misplacement of `txp'
> > + Document our -CURRENT debugging bits
>
> 1) The comments wrap beyongd 80 cols which is not very aesthetic :)
I know. I could not figure out how to make them shorter w/o them
loosing content. Suggestions desired.
> They also don't have a space after the # character.
Nor does the options from INET thru P1003_1B -- I was just following the
style I saw.
> 2) INVARIANT_SUPPORT does not enable any extra checks, it just provides
> support code that sanity checks may call (such as the _mtx_assert()
> function that backs mtx_assert()).
I didn't use the word "enable" for INVARIANT_SUPPORT, only INVARIANT. :-)
> 3) WITNESS is not mutex checks, it is checks for locks in general. It's true
> that lockmgr doesn't yet call witness, but that might be done in the
> future, and sx locks already use WITNESS as well.
From NOTES:
# WITNESS enables the mutex witness code which detects deadlocks and
# cycles during locking operations.
Perhaps you could clarify the comment there?
> 4) Witness does not detect deadlocks.
See the extract of NOTES above. :=)
Diffs to my commit to better clarify things would gladly be accepted.
--
-- David (obrien@FreeBSD.org)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010924130519.A25323>