Date: Sun, 15 May 2011 14:14:53 +0800 From: Jui-Nan Lin <jnlin@csie.nctu.edu.tw> To: Doug Barton <dougb@freebsd.org> Cc: Greg Larkin <glarkin@freebsd.org>, cvs-ports@freebsd.org, Erik Steigler <erik@okcupid.com>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/scribe Makefile ports/net/scribe/files scribe.in Message-ID: <BANLkTi=-i%2BAs=sL8ZTbQt6YkCaADg8Tb=g@mail.gmail.com> In-Reply-To: <4DCF0192.6030808@FreeBSD.org> References: <201105131353.p4DDrtms046413@repoman.freebsd.org> <4DCF0192.6030808@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, This patch does not work on my installation. jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestart Starting scribe. jnlin@Florence [2:14pm] [W2] ~> sudo cat /var/run/scribe.pid && echo 38550 jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestop scribe not running? (check /var/run/scribe.pid). On Sun, May 15, 2011 at 6:26 AM, Doug Barton <dougb@freebsd.org> wrote: > Adding set_rcvar is the right solution for the problem described in the P= R, > but the other changes are going in the wrong direction. Any time you(pl.) > feel compelled to re-write start_cmd it is almost universally the wrong > answer. > > In the attached patch: > 1. Miscellaneous whitespace fixes (style issue, non-critical) > 2. Change REQUIRE to LOGIN which is what is typically done for local > scripts. If there is some reason that it needs to be run earlier this can= be > omitted. > 3. Add KEYWORD shutdown which should be present for scripts that start a > persistent service so that they can be shutdown cleanly. > 4. Use daemon as the command which is how this is sort of thing is typica= lly > done. > 5. Remove the default-empty _flags assignment (neither necessary or > desirable). > 6. Put the right arguments into command_args to make command=3Ddaemon wor= k > properly. > > Please test these changes. Maintainer can you please respond in a timely > manner? :) > > > Thanks, > > Doug > > > On 05/13/2011 06:53, Greg Larkin wrote: >> >> glarkin =C2=A0 =C2=A0 2011-05-13 13:53:55 UTC >> >> =C2=A0 FreeBSD ports repository >> >> =C2=A0 Modified files: >> =C2=A0 =C2=A0 net/scribe =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Makefile >> =C2=A0 =C2=A0 net/scribe/files =C2=A0 =C2=A0 scribe.in >> =C2=A0 Log: >> =C2=A0 - Fixed rc.d script so it adheres to rc.conf setting [1] >> =C2=A0 - Added missing dependency on devel/py-thrift >> =C2=A0 - Bumped PORTREVISION >> >> =C2=A0 PR: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ports/154942 (based= on) >> =C2=A0http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D154942 >> =C2=A0 Submitted by: =C2=A0 Erik Steigler<erik@okcupid.com> =C2=A0[1] >> =C2=A0 Approved by: =C2=A0 =C2=A0maintainer timeout (18 days) >> >> =C2=A0 Revision =C2=A0Changes =C2=A0 =C2=A0Path >> =C2=A0 1.6 =C2=A0 =C2=A0 =C2=A0 +4 -2 =C2=A0 =C2=A0 =C2=A0ports/net/scri= be/Makefile >> =C2=A0 1.2 =C2=A0 =C2=A0 =C2=A0 +16 -3 =C2=A0 =C2=A0 ports/net/scribe/fi= les/scribe.in >> >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/Makefile.diff?&r1= =3D1.5&r2=3D1.6&f=3Dh >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/files/scribe.in.d= iff?&r1=3D1.1&r2=3D1.2&f=3Dh >> > > > > -- > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Nothin' ever doesn't change, but nothin' chang= es much. > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0-- OK Go > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Breadth of IT experience, and depth of knowled= ge in the DNS. > =C2=A0 =C2=A0 =C2=A0 =C2=A0Yours for the right price. =C2=A0:) =C2=A0http= ://SupersetSolutions.com/ > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=-i%2BAs=sL8ZTbQt6YkCaADg8Tb=g>