Date: Sun, 15 May 2011 14:14:53 +0800 From: Jui-Nan Lin <jnlin@csie.nctu.edu.tw> To: Doug Barton <dougb@freebsd.org> Cc: Greg Larkin <glarkin@freebsd.org>, cvs-ports@freebsd.org, Erik Steigler <erik@okcupid.com>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/scribe Makefile ports/net/scribe/files scribe.in Message-ID: <BANLkTi=-i%2BAs=sL8ZTbQt6YkCaADg8Tb=g@mail.gmail.com> In-Reply-To: <4DCF0192.6030808@FreeBSD.org> References: <201105131353.p4DDrtms046413@repoman.freebsd.org> <4DCF0192.6030808@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, This patch does not work on my installation. jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestart Starting scribe. jnlin@Florence [2:14pm] [W2] ~> sudo cat /var/run/scribe.pid && echo 38550 jnlin@Florence [2:14pm] [W2] ~> sudo /usr/local/etc/rc.d/scribe onestop scribe not running? (check /var/run/scribe.pid). On Sun, May 15, 2011 at 6:26 AM, Doug Barton <dougb@freebsd.org> wrote: > Adding set_rcvar is the right solution for the problem described in the PR, > but the other changes are going in the wrong direction. Any time you(pl.) > feel compelled to re-write start_cmd it is almost universally the wrong > answer. > > In the attached patch: > 1. Miscellaneous whitespace fixes (style issue, non-critical) > 2. Change REQUIRE to LOGIN which is what is typically done for local > scripts. If there is some reason that it needs to be run earlier this can be > omitted. > 3. Add KEYWORD shutdown which should be present for scripts that start a > persistent service so that they can be shutdown cleanly. > 4. Use daemon as the command which is how this is sort of thing is typically > done. > 5. Remove the default-empty _flags assignment (neither necessary or > desirable). > 6. Put the right arguments into command_args to make command=daemon work > properly. > > Please test these changes. Maintainer can you please respond in a timely > manner? :) > > > Thanks, > > Doug > > > On 05/13/2011 06:53, Greg Larkin wrote: >> >> glarkin 2011-05-13 13:53:55 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net/scribe Makefile >> net/scribe/files scribe.in >> Log: >> - Fixed rc.d script so it adheres to rc.conf setting [1] >> - Added missing dependency on devel/py-thrift >> - Bumped PORTREVISION >> >> PR: ports/154942 (based on) >> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=154942 >> Submitted by: Erik Steigler<erik@okcupid.com> [1] >> Approved by: maintainer timeout (18 days) >> >> Revision Changes Path >> 1.6 +4 -2 ports/net/scribe/Makefile >> 1.2 +16 -3 ports/net/scribe/files/scribe.in >> >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/Makefile.diff?&r1=1.5&r2=1.6&f=h >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/scribe/files/scribe.in.diff?&r1=1.1&r2=1.2&f=h >> > > > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=-i%2BAs=sL8ZTbQt6YkCaADg8Tb=g>