Date: Fri, 17 Aug 2018 11:06:27 -0600 From: Warner Losh <imp@bsdimp.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... Message-ID: <CANCZdfqFrhzOYcJdQwK06CmJnNm1pf8Qobta7r_cgmPttnn-Uw@mail.gmail.com> In-Reply-To: <CAG6CVpUW7VkTvNNWe3n%2Bqyw3rgu2Tgipp323M7N7M7mJMQdXfA@mail.gmail.com> References: <cem@FreeBSD.org> <201808170023.w7H0Np0H027296@repo.freebsd.org> <201808170503.w7H53GR9023607@slippy.cwsent.com> <CAG6CVpXHWN7%2BNqoVKxMuvrKsbhO2pC%2BqbuYEDnNp8H-k5ubk6w@mail.gmail.com> <CANCZdfoOvTAM-u2Nj4cVBbPT9xhKBhZkEdm2MCv9bVnmuZXT%2Bw@mail.gmail.com> <CAG6CVpUW7VkTvNNWe3n%2Bqyw3rgu2Tgipp323M7N7M7mJMQdXfA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 17, 2018 at 10:17 AM, Conrad Meyer <cem@freebsd.org> wrote: > On Fri, Aug 17, 2018 at 9:12 AM, Warner Losh <imp@bsdimp.com> wrote: > > > > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer <cem@freebsd.org> wrote: > >> We don't intend[sic] on tailoring it at all. > > > > We don't document such an exception... history tells me this belief may > be > > optimistic.. > > I think it is a generally understood convention re: contrib code. I > called out intent in the commit message for the directory, and anyway > it is generally frowned upon in the project to modify contrib code for > non-abandoned upstreams. E.g., there was quite a bit of resistance > modifying top(1) until it was deemed dead upstream and moved out of > contrib. > I don't understand this answer. It makes no sense to me. It certainly doesn't justify flaunting established project guidelines for dubious reasons. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqFrhzOYcJdQwK06CmJnNm1pf8Qobta7r_cgmPttnn-Uw>