Date: Mon, 19 Apr 2004 18:24:42 +0200 From: Andreas Kohn <andreas.kohn@gmx.net> To: Luigi Rizzo <rizzo@icir.org> Cc: current@freebsd.org Subject: [SOLVED] Re: Page fault in rt_newaddrmsg on gif0 destruction Message-ID: <1082391882.786.0.camel@klamath.syndrom23.de> In-Reply-To: <20040419013627.A88297@xorpc.icir.org> References: <1082303878.855.6.camel@klamath.syndrom23.de> <20040419013627.A88297@xorpc.icir.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, 2004-04-19 at 10:36, Luigi Rizzo wrote: > Ok i understand what is going on (thanks for the very detailed > report, btw) -- basically the code was trying to use > ifadd_byindex() after the information had been destroyed. > > I think the attached patch (basically mving a block of code down > in if_detach) should fix the problem. > > Actually I believe this particular chunk of code should be moved > even further down, possibly right before the final IF_AFDATA_UNLOCK(), > because you cannot tell, a-priori, what information on the device > the lower level routines expect to use, so zeroing the ifindex_table[] > or calling destroy_dev() too early is probably a bug. > > If you can try it (in the proposed form, or moving it at the end > of if_detach) and let me khow how it works for you, i can commit > the fix. > > cheers > luigi Hi, thank you, that one works perfectly. Regards, Andreas [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAg/1KYucd7Ow1ygwRAs79AJ9OA6sb0vpYXYvGkozgL6/IymWLtgCeLHjG q6HkWo6fZZ1XH3KQEBT5ERc= =bWlO -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1082391882.786.0.camel>