Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 02 Apr 2020 20:48:34 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 245296] [patch] ruptime leaves spurious extra spaces for the load average of machines that are down
Message-ID:  <bug-245296-227@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245296

            Bug ID: 245296
           Summary: [patch] ruptime leaves spurious extra spaces for the
                    load average of machines that are down
           Product: Base System
           Version: 11.3-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: martin@lispworks.com

Created attachment 212992
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D212992&action=
=3Dedit
Fix maxloadav calculation

The calculation for maxloadav in usr.bin/ruptime/ruptime.c includes machines
that are down, even though the load averages for those machines are not
printed.  This can leave spurious extra spaces when printing the load avera=
ges
if a machine is down with a load >=3D 10.

For example, I see output like this with two spaces before the 0.00 for
methane:

methane                    up    6+10:55,     0 users,  load  0.00,  0.00,=
=20
0.00
odroid                   down      20:10

because the load average for odroid was 28 before it stopped responding.

It should be like this:

methane                    up    6+10:55,     0 users,  load 0.00, 0.00, 0.=
00
odroid                   down      20:10

This is fixed by the attached patch.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-245296-227>