Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Sep 2025 21:05:28 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Colin Percival <cperciva@tarsnap.com>
Cc:        Konstantin Belousov <kib@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 94a0f9f63e16 - main - kern/vfs_vnops.c: generalize the lock primitive for file foffset
Message-ID:  <aM2baG1uGgvSib9y@kib.kiev.ua>
In-Reply-To: <0100019963022db0-d88b1d01-e0f3-4ec3-9838-a7f8f66f6c1f-000000@email.amazonses.com>
References:  <202509191419.58JEJrSZ031832@gitrepo.freebsd.org> <0100019963022db0-d88b1d01-e0f3-4ec3-9838-a7f8f66f6c1f-000000@email.amazonses.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 19, 2025 at 05:25:11PM +0000, Colin Percival wrote:
> On 9/19/25 07:19, Konstantin Belousov wrote:
> > commit 94a0f9f63e164e4f3791bc7d105d6f267b4d47bc
> > 
> >      kern/vfs_vnops.c: generalize the lock primitive for file foffset
> >
> > +	atomic_clear_16(flagsp, lock_bit | lock_wait_bit);
> 
> Jenkins says this breaks powerpc64:
> 
> /usr/src/sys/kern/vfs_vnops.c:852:2: error: call to undeclared function
> 'atomic_clear_16'; ISO C99 and later do not support implicit function
> declarations [-Werror,-Wimplicit-function-declaration]
>   852 |         atomic_clear_16(flagsp, lock_bit | lock_wait_bit);
>       |         ^
> /usr/src/sys/kern/vfs_vnops.c:852:2: note: did you mean 'atomic_clear_int'?

D52626 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aM2baG1uGgvSib9y>