Date: Mon, 05 Jan 2009 21:15:28 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec Message-ID: <49626A60.70808@gmx.de> In-Reply-To: <20090105194210.P45399@maildrop.int.zabbadoz.net> References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> <alpine.BSF.2.00.0901042213530.67103@fledge.watson.org> <20090105172400.T45399@maildrop.int.zabbadoz.net> <49624DB9.8080900@gmx.de> <20090105194210.P45399@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Bjoern A. Zeeb schrieb: > On Mon, 5 Jan 2009, Christoph Mallon wrote: >> Bjoern A. Zeeb schrieb: >>> I have broken it out from a larger patch; the C99 initializer is here: >>> http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff >>> >>> I case someone can give it a quick glance I'll commit them. >> >> + .pr_flags = PR_ATOMIC|PR_ADDR, >> >> style(9) wants spaces around binary operators. > > I am not sure it does. "Unary operators do not require spaces, binary operators do." I guess only "usual" binary operators are meant here and it does not include ",", "[]" or "->". > In case it does I am not going to break > consistency with all other 65 places that don't do for pr_flags; You have a point there. Maybe these should be fixed all at once. > but it seems I should change the <tab>=<space> to <space>=<tab>. <tab> /after/ =? This sounds wrong to me. (In general I think using <tab> for alignment is a bad idea and it should only be used for indentation)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49626A60.70808>