Date: Tue, 5 Aug 2003 08:55:54 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Diomidis Spinellis <dds@aueb.gr> Cc: Johan Karlsson <johan@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/sym sym_fw.h Message-ID: <20030805155554.GA95218@dragon.nuxi.com> In-Reply-To: <3F2FAE21.6EEB6309@aueb.gr> References: <200308050722.h757MCxl098780@repoman.freebsd.org> <20030805122815.GA17099@numeri.campus.luth.se> <3F2FAE21.6EEB6309@aueb.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 05, 2003 at 04:16:17PM +0300, Diomidis Spinellis wrote: > > > Log: > > > Remove extraneous semicolons. They are already provided by > > > the macro definition, and cause the generation of syntactically > > > incorrect code that gcc happens to accept. > > > > This is backwards. > > >From style(9): > > Any final statement-ter- > > minating semicolon should be supplied by the macro invocation rather than > > the macro, to make parsing easier for pretty-printers and editors. > > > > Please consider reverting this and change the macros in the file to not > > supply the terminating semicolon. > > I would certainly follow the style(9) guide if the existing code allowed > it. Please realize that this driver is shared with other OS's.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030805155554.GA95218>