Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Mar 2012 20:22:24 +0200
From:      Marius Strobl <marius@alchemy.franken.de>
To:        Alexander Kabaev <kabaev@gmail.com>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r233288 - in head/sys: boot/common libkern sys
Message-ID:  <20120326182224.GU37560@alchemy.franken.de>
In-Reply-To: <20120325162528.7f73300c@kan.dyndns.org>
References:  <201203212055.q2LKtMYR093218@svn.freebsd.org> <20120325162528.7f73300c@kan.dyndns.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 25, 2012 at 04:25:28PM -0400, Alexander Kabaev wrote:
> On Wed, 21 Mar 2012 20:55:22 +0000 (UTC)
> Marius Strobl <marius@FreeBSD.org> wrote:
> 
> <SKIP>
> > Modified: head/sys/sys/libkern.h
> > ==============================================================================
> > --- head/sys/sys/libkern.h	Wed Mar 21 20:53:47 2012
> > (r233287) +++ head/sys/sys/libkern.h	Wed Mar 21 20:55:21
> > 2012	(r233288) @@ -121,7 +121,7 @@ size_t	 strspn(const
> > char *, const char char	*strstr(const char *, const char *);
> >  int	 strvalid(const char *, size_t);
> >  
> > -extern uint32_t crc32_tab[];
> > +extern const uint32_t const crc32_tab[];
> >  
> >  static __inline uint32_t
> >  crc32_raw(const void *buf, size_t size, uint32_t crc)
> 
> Hi,
> 
> 
> g++ produces "error: duplicate 'const'" on this changed line. Leaving
> the question as to why this file is ever being compiled by C++ on the
> conscience of of VirtualBox authors, I would suggest partially backing
> out this commit and getting easier on 'const' for C++'s sake. 
> 

Done in r233517.

Marius




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120326182224.GU37560>