Date: Tue, 19 Aug 2025 14:09:18 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 3d4d778262e4 - main - random: Correct wording in a comment Message-ID: <202508191409.57JE9Ild021796@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3d4d778262e459c9c80781a3474908d090ffb061 commit 3d4d778262e459c9c80781a3474908d090ffb061 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2025-08-19 14:04:57 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2025-08-19 14:04:57 +0000 random: Correct wording in a comment In the calculation of the cutoff value, we haven't changed the window size itself, just the example formula, which takes the window size as a parameter. Reviewed by: cem Fixes: f92ff79720fb ("random: Add NIST SP 800-90B entropy source health test implementations") Sponsored by: Stormshield Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D52002 --- sys/dev/random/random_harvestq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/random/random_harvestq.c b/sys/dev/random/random_harvestq.c index c7762967c4fb..ced15262457f 100644 --- a/sys/dev/random/random_harvestq.c +++ b/sys/dev/random/random_harvestq.c @@ -493,9 +493,9 @@ random_healthtest_init(enum random_entropy_source source) * The RCT limit comes from the formula in section 4.4.1. * * The APT cutoff is calculated using the formula in section 4.4.2 - * footnote 10 with the window size changed from 512 to 511, since the - * test as written counts the number of samples equal to the first - * sample in the window, and thus tests W-1 samples. + * footnote 10 with the number of Bernoulli trials changed from W to + * W-1, since the test as written counts the number of samples equal to + * the first sample in the window, and thus tests W-1 samples. */ ht->ht_rct_limit = 35; ht->ht_apt_cutoff = 330;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202508191409.57JE9Ild021796>