Date: Mon, 4 Aug 2014 19:23:52 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Garrett Cooper <ngie@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target Message-ID: <20140804185707.P7764@besplex.bde.org> In-Reply-To: <53df1ed9.5830.34b38bca@svn.freebsd.org> References: <53df1ed9.5830.34b38bca@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 Aug 2014, Garrett Cooper wrote:
> Log:
> Move a -L argument from LDADD to LDFLAGS
>
> Phabric: D525 (part of a larger patch)
>
> Reviewed by: jmmv
> Approved by: jmmv (co-mentor)
>
> Modified:
> head/libexec/rtld-elf/tests/target/Makefile
>
> Modified: head/libexec/rtld-elf/tests/target/Makefile
> ==============================================================================
> --- head/libexec/rtld-elf/tests/target/Makefile Mon Aug 4 05:46:10 2014 (r269504)
> +++ head/libexec/rtld-elf/tests/target/Makefile Mon Aug 4 05:49:13 2014 (r269505)
> @@ -6,7 +6,9 @@ PROG= target
> BINDIR= ${TESTSBASE}${TESTSDIR}/libexec/rtld-elf
>
> CFLAGS+= -I${.CURDIR}/../libpythagoras
> -LDADD= -L${.OBJDIR}/../libpythagoras -lpythagoras
> +
> +LDFLAGS+= -L${.OBJDIR}/../libpythagoras
> +LDADD= -lpythagoras
>
> MAN=
I hope this fixes the error found by "make checkdpadd". -L is too hard
for the current "make checkdpadd" to handle. Old aout versions worked
better using linker support. They also found the correct dependencies
(on shared libraries for shared linkage, not the pseudo-dependenci on
the hard-coded static librar for shared linkage).
"make checkdpadd" currently finds broken 143 makefiles with inconsistent
DPADD. 62 of them are for clang. Most of these misuse DPADD for
headers. The next largest source of errors is libtermcapw. LIBTERMCAPW
is missing in bsd.libnames.mk. This breaks about 29 makefiles where
LIBTERMCAP was blindly replaced by LIBTERMCAPW. bsd.libnames.mk and
DPADD were unnecessary with the old aout versions.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140804185707.P7764>