Date: Mon, 18 Jun 2001 11:24:49 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/fstat fstat.c Message-ID: <20010618112449.A95135@dragon.nuxi.com> In-Reply-To: <20010618120130.G1713@ringworld.oblivion.bg>; from roam@orbitel.bg on Mon, Jun 18, 2001 at 12:01:30PM %2B0300 References: <200106180629.f5I6TVs70841@freefall.freebsd.org> <20010618115221.D56404@sunbay.com> <20010618120130.G1713@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 18, 2001 at 12:01:30PM +0300, Peter Pentchev wrote: > <quote> > And btw, no, I don't think it is worth it in this particular case > to separate functionality and whitespace changes. Even the untrained > eye can easily see that the first and third chunk are no-ops :) > </quote> If parts of it are NOPs, it should be a separate commit. Period. > BTW, do people feel that I should back this change out, and redo it > in two separate commits? No, the damage is done. Please follow established practices in the future. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010618112449.A95135>