Date: Sun, 8 Mar 2020 13:15:12 +0000 From: <Shichun.Ma@dell.com> To: <hps@selasky.org>, <freebsd-usb@freebsd.org> Cc: <Shunchao.Hu@dell.com> Subject: RE: Error bit using of wPortStatus when need usbd_req_warm_reset_port Message-ID: <985d07eb112c4497a7dd95f72e3d8134@KULX13MDC130.APAC.DELL.COM> In-Reply-To: <8b8ae413-29d2-1b0b-1037-cf3b49c1baf7@selasky.org> References: <13174e356c0640ab84fd697a1ae28e55@KULX13MDC130.APAC.DELL.COM> <8b8ae413-29d2-1b0b-1037-cf3b49c1baf7@selasky.org>
index | next in thread | previous in thread | raw e-mail
Dell Customer Communication - Confidential Hi HPS, Thanks your kindly explanation. The patch works with my device, please commit to main stream. Regards, Horse Ma (Shichun Ma) Software Engineer Dell | Cloud client-computing - Wyse office +86 10 82862579, Mobile +86 13241851528 See our products at www.dell.com/wyse -----Original Message----- From: Hans Petter Selasky <hps@selasky.org> Sent: Sunday, March 8, 2020 8:40 PM To: Ma, Horse; freebsd-usb@freebsd.org Cc: Hu, Shunchao Subject: Re: Error bit using of wPortStatus when need usbd_req_warm_reset_port [EXTERNAL EMAIL] On 2020-03-08 12:15, Shichun.Ma@dell.com wrote: > Link info need 4 bits and they take bit 5 to bit 9, while UPS_PORT_POWER takes bit 9. > So this will give wrong link state info in function uhub_suspend_resume_port when it check if need usbd_req_warm_reset_port. > Please review and kindly suggest how to fix this issue. Hi, You are absolutely right. Good catch. I think we will just remove the POWER bit from the super speed RH. It is currently not needed for anything. Then the LINK state values won't be clobbered like you found. Does the attached patch work for you? --HPShome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?985d07eb112c4497a7dd95f72e3d8134>