Date: Thu, 14 May 2009 01:47:38 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: alpha@freebsd.org, hackers@freebsd.org Subject: PTE modified bit emulation trap Message-ID: <86tz3o4lb9.fsf@ds4.des.no>
next in thread | raw e-mail | index | archive | help
Coverity complains about the lack of error checking in the following
code in sys/kern/kern_sysctl.c, around line 1390:
/*
* Touch all the wired pages to avoid PTE modified
* bit emulation traps on Alpha while holding locks
* in the sysctl handler.
*/
for (i =3D (wiredlen + PAGE_SIZE - 1) / PAGE_SIZE,
cp =3D req->oldptr; i > 0; i--, cp +=3D PAGE_SIZE) {
copyin(cp, &dummy, 1);
copyout(&dummy, cp, 1);
}
Since Alpha is dead, can we remove this, or is it still needed for other
platforms?
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tz3o4lb9.fsf>